Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devnet update #108

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Devnet update #108

merged 2 commits into from
Feb 17, 2025

Conversation

piotr-iohk
Copy link
Collaborator

Test adjustments after recent rosetta devnet upgrade:

  • devnet network_id from 'testnet' to 'devnet' (24d4eb9)
  • temporarily disable search_tx comparison tests (f612cc9)

@piotr-iohk piotr-iohk requested a review from simisimis February 17, 2025 11:28
@piotr-iohk piotr-iohk self-assigned this Feb 17, 2025
simisimis
simisimis approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the purpose of commenting things out instead of removing, but you must have a reason

@piotr-iohk
Copy link
Collaborator Author

Not sure what's the purpose of commenting things out instead of removing, but you must have a reason

The reason is that devnet Rosetta Ocaml is failing on /search/transaction requests, which is either a bug or config issue. Until it is sorted I wanted to disable the comparison tests against this endpoint such that we can pass the CI and continue working on MinaMesh.

@piotr-iohk piotr-iohk merged commit c8f1346 into main Feb 17, 2025
6 checks passed
@piotr-iohk piotr-iohk deleted the devnet-update branch February 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simisimis simisimis simisimis approved these changes

@joaosreis joaosreis Awaiting requested review from joaosreis joaosreis is a code owner

@johnmarcou johnmarcou Awaiting requested review from johnmarcou johnmarcou is a code owner

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @simisimis